Add parameter erase_even_duplicates to PMP::repair_polygon_soup#9373
Open
Add parameter erase_even_duplicates to PMP::repair_polygon_soup#9373
Conversation
Contributor
Author
|
/build:v0 |
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9373/v0/Manual/index.html |
Member
|
Maybe you want to add a test to ensure the behavior is not broken at some point. |
MaelRL
reviewed
Mar 12, 2026
PMP_Mesh_repair/include/CGAL/Polygon_mesh_processing/repair_polygon_soup.h
Outdated
Show resolved
Hide resolved
PMP_Mesh_repair/include/CGAL/Polygon_mesh_processing/repair_polygon_soup.h
Outdated
Show resolved
Hide resolved
MaelRL
added
Not yet approved
Member
|
Please write a small feature, and cross link. |
afabri
changed the title
afabri
reviewed
Mar 16, 2026
PMP_Mesh_repair/test/PMP_Mesh_repair/test_repair_polygon_soup.cpp
Outdated
Show resolved
Hide resolved
afabri
reviewed
Mar 16, 2026
PMP_Mesh_repair/include/CGAL/Polygon_mesh_processing/repair_polygon_soup.h
Outdated
Show resolved
Hide resolved
afabri
reviewed
Mar 16, 2026
PMP_Mesh_repair/include/CGAL/Polygon_mesh_processing/repair_polygon_soup.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
Contributor
Author
|
/build:v1 |
|
There was an error while building the doc: |
Contributor
Author
|
/force-build:v1 |
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9373/v1/Manual/index.html |
sloriot
reviewed
Mar 16, 2026
PMP_Mesh_repair/include/CGAL/Polygon_mesh_processing/repair_polygon_soup.h
Outdated
Show resolved
Hide resolved
sloriot
reviewed
Mar 16, 2026
PMP_Mesh_repair/include/CGAL/Polygon_mesh_processing/repair_polygon_soup.h
Show resolved
Hide resolved
sloriot
reviewed
Mar 16, 2026
PMP_Mesh_repair/include/CGAL/Polygon_mesh_processing/repair_polygon_soup.h
Outdated
Show resolved
Hide resolved
…sts of the interaction between the deprecated and the new parameter
… into PMP-erase_even_duplicates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Add
erase_even_duplicatesparameter toPMP::repair_polygon_soup(). If set totrueand an even number of polygons are duplicates, all duplicates are removed instead of keeping one.This option is useful when transforming a manifold mesh may pinch parts of the mesh and create duplicate faces. Removing duplicates in pairs guarantees that non-manifold edges have an even number of incident faces, which helps restore a consistent mesh structure without creating holes.
Release Management